Each of them is one fix for testing purposes, as they are quite unrelated code-wise.FlavioB wrote:Thanks for your work!rv0 wrote:Created 2 new Pull Requests on Github:
1) Fix the Sync modes in Track mode
When I previously rewrote how sync is managed in the "edit" modes of pattern play, I totally ignored Track mode.
Here I fix this.
Also fixes issue when pressing "Next" in track mode would cause desync of clock. If anyone wants to test this change:
https://rv0.be/tmp/yocto_firmware_1_2_Track_Mode.syx
2) Fix sync issues in pattern edit when using midi slave mode
This should also improve the Tap entry and Tap-removal
If anyone wants to test:
https://rv0.be/tmp/yocto_firmware_1_2_F ... n_Edit.syx
Have fun
Do the two files contain both fixes, or each of them is one fix - based on 1.2a?
Will you merge those fixes into 1.2b eventually?
Thanks,
Flavio.
Please help by testing both version in your setup
The code has been submitted for review on the official-unoffical repo maintained by helectromagneticus
https://github.com/HomoElectromagneticu ... _808/pulls
I'm sure once he finds the time to have a look at the changes and test them that he will merge the changes and create a new release.
I started doing a major refactor btw.. But there's a ton of work to be done.. Basically changing the whole way the sequencer works under the hood... But thats for later.. Probably not for this year even If @helectromagneticus is reading this, please help me decide on code style, as things will go a lot quicker for me after doing an automated reformat on _ALL_ the things